Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specconv: always set "type: bind" in case of MS_BIND #2035

Merged
merged 1 commit into from
May 7, 2019
Merged

specconv: always set "type: bind" in case of MS_BIND #2035

merged 1 commit into from
May 7, 2019

Commits on Apr 8, 2019

  1. specconv: always set "type: bind" in case of MS_BIND

    We discovered in umoci that setting a dummy type of "none" would result
    in file-based bind-mounts no longer working properly, which is caused by
    a restriction for when specconv will change the device type to "bind" to
    work around rootfs_linux.go's ... issues.
    
    However, bind-mounts don't have a type (and Linux will ignore any type
    specifier you give it) because the type is copied from the source of the
    bind-mount. So we should always overwrite it to avoid user confusion.
    
    Signed-off-by: Aleksa Sarai <asarai@suse.de>
    cyphar committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    8296826 View commit details
    Browse the repository at this point in the history