Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

travis: update configuration #2222

Merged
merged 1 commit into from
Mar 6, 2020
Merged

travis: update configuration #2222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
dist: bionic
language: go
go:
- 1.11.x
- 1.12.x
- 1.13.x
- 1.x
- tip

matrix:
include:
- go: 1.12.x
name: "cgroup-systemd"
env:
- RUNC_USE_SYSTEMD=1
script:
- make BUILDTAGS="${BUILDTAGS}" all
- sudo PATH="$PATH" make localintegration RUNC_USE_SYSTEMD=1
- go: 1.12.x
name: "cgroup-v2"
env:
- VIRTUALBOX_VERSION=6.0
- VAGRANT_VERSION=2.2.6
Expand All @@ -29,6 +32,7 @@ matrix:
- ssh default sudo podman run --privileged --cgroupns=private test make localunittest
allow_failures:
- go: tip
- name: "cgroup-v2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add retry code to the v2 setup script instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, but the v2 tests also take the longest to run -- I'm not a huge fan of the idea of having possibly-regular >1hr test runs.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyphar: I'm not a huge fan of the idea of having possibly-regular >1hr test runs.

Compared to how little the CI is exercised here, that seems like an acceptable trade-off for not breaking things...? "Acceptable failures" often quickly degenerate unless someone pays close attention to them. Wouldn't it be better to try to figure out what's causing the flakes and fixing that?


go_import_path: github.com/opencontainers/runc

Expand Down