Actually check for syscall.ENODEV when checking if a container is paused #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that ioutil.Readfile wraps the error in a *os.PathError. Since we cannot guarantee compilation with golang >= v1.13, we are manually unwrapping the error. Signed-off-by: Kieron Browne <kbrowne@pivotal.io>
|
LGTM |
1 similar comment
|
LGTM |
Actually, we have switched to golang 1.13+ once we merged #2256. Also, since go 1.12 is an unsupported version, it makes no sense to try supporting it. Can we please use errors.Unwrap() instead (and maybe mark the file with |
|
Another (non-technical) problem with this commit is it is not signed-off-by by the author (and our DCO check fails to see it). I mean:
|
|
Opened #2280 to use errors.Unwrap() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that ioutil.Readfile wraps the error in a *os.PathError.
Since we cannot guarantee compilation with golang >= v1.13, we are
manually unwrapping the error.
Signed-off-by: Kieron Browne kbrowne@pivotal.io