Restorefixforrunningcontainer #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajasekaran <rajasec79@gmail.com>
rajasec
force-pushed
the
restore-leaverunning
branch
from
2dd0acf
to
77af09e
Compare
|
@mrunalp @crosbymichael |
|
@rajasec I just kicked it off for you. |
|
Thanks. |
|
LGTM ping @crosbymichael @avagin @boucher |
|
LGTM |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
…ners Add @hqhq as maintainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the runc, I've started the container by setting the terminal as false for checkpointing. In second terminal gave the command runc checkpoint --leave-running,
Checkpoint happened successfully and at the same time container running in first terminal is not stopped which is expected behavior.
In the second terminal I typed runc restore, this also started the container.
with single ID runc, two instances of runc were running.
Upon killing ./runc restore, it failed to remove the cgroup paths.
So I've added the check in restore, if the container with specific ID is already running, give an message saying " Container with ID already running".
Signed-off-by: Rajasekaran rajasec79@gmail.com