Adapt spec 96bcd043aa8a28f6f64c95ad61329765f01de1ba #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
force-pushed
the
adapt-spec-96bcd043aa8a28f6f64c95ad61329765f01de1ba
branch
4 times, most recently
from
ca6a6cf
to
5093b08
Compare
runcom
force-pushed
the
adapt-spec-96bcd043aa8a28f6f64c95ad61329765f01de1ba
branch
4 times, most recently
from
2e090e9
to
d7edd30
Compare
runcom
force-pushed
the
adapt-spec-96bcd043aa8a28f6f64c95ad61329765f01de1ba
branch
3 times, most recently
from
4c0d567
to
ac80ee8
Compare
|
Ping @LK4D4 @crosbymichael |
|
LGTM |
Godeps: Vendor opencontainers/specs 96bcd04 Fix a bug where it's impossible to pass multiple devices to blkio cgroup controller files. See opencontainers#274 Signed-off-by: Antonio Murdaca <runcom@linux.com>
runcom
force-pushed
the
adapt-spec-96bcd043aa8a28f6f64c95ad61329765f01de1ba
branch
from
ac80ee8
to
c6e406a
Compare
|
I've rebased this, though it seems the specs version I'm importing here is quite old now. I'll vendor the latest commit and adapt code if it's ok for you @crosbymichael @LK4D4 @mrunalp |
|
Looks like this is blocking two PR's in docker (moby/moby#13959 (comment)), any chance of moving this forward? ❤️ |
|
Reviewing... |
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Oct 5, 2015
…ad61329765f01de1ba Adapt spec 96bcd04
|
I'll update docker now, thanks @crosbymichael @mrunalp |
|
Thanks all! |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
source and schema: differentiate with examples
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
The label changed in 5a8a779 (Move process specific settings to process, 2016-03-02, opencontainers#329) and 7bf06d5 (source and schema: differentiate with examples, 2015-12-18, opencontainers#276) missed this instance when rebasing around opencontainers#329. Signed-off-by: W. Trevor King <wking@tremily.us>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Also: * Update the link to Go bindings after 7bf06d5 (source and schema: differentiate with examples, 2015-12-18, opencontainers#276). * Add a reference to the JSON Schema after cdcabde (schema: JSON Schema and validator for `config.json`, 2016-01-19, opencontainers#313). It's pretty clear that the Go bindings cannot be canonical on their own, because they do not define limits (e.g. the 0 through 512 range for FileMode). The JSON Schema is closer, but still does not cover everything (e.g. "a directory must exist at root.path"). Both the Go bindings and the JSON Schema could grow to cover the full spec by adding that sort of thing to comments and descriptions, but that's not how things seem to be working now. Signed-off-by: W. Trevor King <wking@tremily.us>
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
Catch up with 7bf06d5 (source and schema: differentiate with examples, 2015-12-18, opencontainers#276). Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #274