Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unify debian and busybox image setup #2764

Closed
wants to merge 1 commit into from

Conversation

zhsj
Copy link
Contributor

@zhsj zhsj commented Jan 24, 2021

Like busybox image, download debian rootfs from GitHub.

Like busybox image, download debian rootfs from GitHub.

Signed-off-by: Shengjing Zhu <zhsj@debian.org>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We should error out when $(go env GOARCH) != amd64 && $(go env GOARCH) != amd64, but the issue is not new in this PR and can be fixed later.

@tianon
Copy link
Member

tianon commented Jan 25, 2021

Lots of overlap here with #2741 😅

@zhsj
Copy link
Contributor Author

zhsj commented Jan 26, 2021

close in favor of #2741

@zhsj zhsj closed this Jan 26, 2021
@zhsj zhsj deleted the debian-image branch January 28, 2021 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants