release: correctly handle binary signing for "make releaseall" #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My GPG keys are not available inside the container, so it makes little sense to try to sign the binaries inside the container's release.sh. The solution is to split things into separate build and sign stages, with signing ocurring after the in-Docker build. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
AkihiroSuda
approved these changes
Dec 7, 2021
Closed
kolyshkin
reviewed
Dec 8, 2021
|
|
||
| # Print usage information. | ||
| function usage() { | ||
| echo "usage: release_sign.sh [-S <gpg-key-id>] [-r <release-dir>]" >&2 |
There was a problem hiding this comment.
This lacks some options (-H, -v)
|
Hmm, can't we just do something like this instead (not tested)? diff --git a/Makefile b/Makefile
index aeb62f8c..c4aff886 100644
--- a/Makefile
+++ b/Makefile
@@ -44,6 +44,7 @@ releaseall: release
release: runcimage
$(CONTAINER_ENGINE) run $(CONTAINER_ENGINE_RUN_FLAGS) \
--rm -v $(CURDIR):/go/src/$(PROJECT) \
+ -v ~/.gnupg:/root/.gnupg:ro \
-e RELEASE_ARGS=$(RELEASE_ARGS) \
$(RUNC_IMAGE) make localrelease |
Theoretically speaking, some malicious image can stole private keys. OTOH if we trust this image in building runc binary which we are releasing, it is to be trusted. |
kolyshkin
approved these changes
Dec 8, 2021
|
I use a hardware token for my GPG keys, so passing the keydir won't work. |
|
Two LGTMs, is this ready to merge? |
|
Yup. The help thing is a minor issue, I can fix it some other time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My GPG keys are not available inside the container, so it makes little
sense to try to sign the binaries inside the container's release.sh. The
solution is to split things into separate build and sign stages, with
signing ocurring after the in-Docker build.
Fixes #3038
Signed-off-by: Aleksa Sarai cyphar@cyphar.com