Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement to set a domainname #3600

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Implement to set a domainname #3600

merged 1 commit into from
Apr 19, 2023
+65 −5

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Sep 11, 2022

AkihiroSuda
AkihiroSuda previously approved these changes Sep 11, 2022
View reviewed changes
@AkihiroSuda
Copy link
Member

Can we have an integration test too?

@utam0k
Copy link
Member Author

utam0k commented Sep 12, 2022

@AkihiroSuda @kolyshkin Thanks for your great review 🙇 I have updated it. Please retake a look at it.

utam0k
utam0k commented Sep 12, 2022
View reviewed changes
tests/integration/dev.bats Outdated Show resolved Hide resolved
@utam0k utam0k requested review from AkihiroSuda and kolyshkin and removed request for AkihiroSuda and kolyshkin September 14, 2022 04:35
@utam0k utam0k requested review from cyphar and removed request for kolyshkin September 15, 2022 12:50
@kolyshkin
Copy link
Contributor

  1. Looks like you need to squash the second commit into the first one.
  2. Not sure why you require root in your test case; I think that UTS namespace works in rootless containers.

@utam0k utam0k force-pushed the domainname branch 2 times, most recently from 7eedf6f to f50ef9b Compare September 23, 2022 07:41
@utam0k
Copy link
Member Author

utam0k commented Sep 23, 2022

@kolyshkin Sorry for the late. May I ask you to review again?

@utam0k utam0k mentioned this pull request Sep 25, 2022
Closed
2 tasks
@utam0k
Copy link
Member Author

utam0k commented Sep 25, 2022

hmm... It seems that the integration test on cent-os7 failed.

# stat: cannot read file system information for ‘/sys/fs/cgroup/unified’: No such file or directory
# /home/runc/tests/integration/helpers.bash: line 76: jq: command not found
# /home/runc/tests/integration/helpers.bash: line 76: jq: command not found

@kolyshkin
Copy link
Contributor

hmm... It seems that the integration test on cent-os7 failed.

This is fixed by #3614, please rebase.

Also PTAL containers/crun#1017

@liubin liubin mentioned this pull request Dec 27, 2022
Open
AkihiroSuda
AkihiroSuda previously approved these changes Jan 31, 2023
View reviewed changes
@AkihiroSuda
Copy link
Member

@kolyshkin LGTY?

@AkihiroSuda
Copy link
Member

Please squash commits

@AkihiroSuda AkihiroSuda mentioned this pull request Feb 1, 2023
Merged
@utam0k
Copy link
Member Author

utam0k commented Feb 1, 2023

Please squash commits

@AkihiroSuda ✅

AkihiroSuda
AkihiroSuda previously approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@utam0k utam0k mentioned this pull request Feb 2, 2023
Merged
@AkihiroSuda
Copy link
Member

Sorry, seems to need rebase to pass the CI

auto-merge was automatically disabled February 14, 2023 11:31

Head branch was pushed to by a user without write access

@utam0k
Copy link
Member Author

utam0k commented Feb 14, 2023

Sorry, seems to need rebase to pass the CI

@AkihiroSuda Thanks for letting me know. How's this?

@AkihiroSuda
Copy link
Member

@kolyshkin LGTY?

@AkihiroSuda AkihiroSuda requested a review from cyphar April 6, 2023 04:25
kolyshkin
kolyshkin reviewed Apr 11, 2023
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase since we've added more jobs to CI.

One nit, looks good otherwise.

@utam0k
Implement to set a domainname
d923060 
opencontainers/runtime-spec#1156

Signed-off-by: utam0k <k0ma@utam0k.jp>
auto-merge was automatically disabled April 12, 2023 13:31

Head branch was pushed to by a user without write access

@AkihiroSuda
Copy link
Member

@kolyshkin LGTY?

kolyshkin
kolyshkin approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin merged commit fdc2515 into opencontainers:main Apr 19, 2023
@YJDoc2
Copy link

YJDoc2 commented Nov 6, 2023

@kolyshkin / @AkihiroSuda may I ask when will this change be added to one of the runc releases? If I'm right, I don't think any of the current released runc has this change added / supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

@cyphar cyphar Awaiting requested review from cyphar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@utam0k @AkihiroSuda @kolyshkin @YJDoc2 @cyphar