Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/gha: add space-at-eol check, fix existing issues #3883

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented May 31, 2023

This adds a new CI check that there's no extra whitespace at EOL, and fixes all existing cases (not much).

Mostly doing it because my $EDITOR is configured to remove extra whitespace at EOL for most file types, and I don't want to introduce extra hunks when working on the docs.

The failed run looks like this:

MAINTAINERS_GUIDE.md:53:* Step 3: Accept (`LGTM`) or refuse a pull request. The relevant maintainers do 
NOTICE:11:United States and other governments.  
....
libcontainer/nsenter/README.md:12:So every time we  import package `nsenter`, the C code function `nsexec()` would be 
^^^ extra whitespace at EOL, please fix

@kolyshkin
Copy link
Contributor Author

Hope this check is not too restrictive:

  • it only works for text files;
  • our Go, C, and shell code is already autoformatted, so this is mostly about docs and CI configs.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin marked this pull request as ready for review June 7, 2023 18:27
@kolyshkin
Copy link
Contributor Author

@AkihiroSuda @thaJeztah PTAL

@AkihiroSuda AkihiroSuda merged commit 5cf9bb2 into opencontainers:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants