Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCheckpoint: skip on ErrCriuMissingFeatures #4146

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

AkihiroSuda
Copy link
Member

No description provided.

libcontainer/criu_linux.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a single nit, otherwise lgtm

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

Addressed the comment

@lifubang
Copy link
Member

lifubang commented Jan 4, 2024

Could you please have a description or link to an issue? To tell us which problem we want to solve.

@AkihiroSuda
Copy link
Member Author

Could you please have a description or link to an issue? To tell us which problem we want to solve.

On actuated, the kernel is not configured to support criu, so the test has to be skipped, even if criu binary is present.

@lifubang
Copy link
Member

lifubang commented Jan 5, 2024

Thanks, we will always skip this test case in any os which is not configured to support criu, so it will cause us silently skip it if we made a mistake when we modify the CI.
Do we need to add some condition check? For example skip only for some specific OS version?

@AkihiroSuda
Copy link
Member Author

Thanks, we will always skip this test case in any os which is not configured to support criu, so it will cause us silently skip it if we made a mistake when we modify the CI. Do we need to add some condition check? For example skip only for some specific OS version?

We have been checking criurpc.CriuReq.Features. Isn't this enough?

@lifubang
Copy link
Member

lifubang commented Jan 5, 2024

I looked into #4142 , it seems that the OS is ubuntu 22.04 in actuated, so maybe we can't skip it only for some os.
My original thought is that we just only skip this test case for the OS in actuated.

@cyphar cyphar merged commit c255024 into opencontainers:main Jan 6, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants