Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script/check-config.sh: fixes and additions #4152

Merged
merged 5 commits into from
Jan 7, 2024
Merged

script/check-config.sh: fixes and additions #4152

merged 5 commits into from
Jan 7, 2024

Commits on Dec 20, 2023

  1. scripts/check-config: don't check MEMCG_SWAP on newer kernels 

    Kernel commit e55b9f96860f (which made its way into Linux v6.1-rc1)
removes CONFIG_MEMCG_SWAP entirely, so there's no sense to check for in
on newer kernels.

Make the check conditional.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    b94b559 View commit details
    Browse the repository at this point in the history

  2. script/check-config: disable colors 

    ...when the stdout is not a terminal, and also when NO_COLOR environment
variable is set to any non-empty value (as per no-color.org).

Co-authored-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin @AkihiroSuda
    kolyshkin and AkihiroSuda committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    6aa4c1a View commit details
    Browse the repository at this point in the history

  3. script/check-config.sh: check CONFIG_CHECKPOINT_RESTORE 

    Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
    @AkihiroSuda @kolyshkin
    AkihiroSuda authored and kolyshkin committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    7f65cc7 View commit details
    Browse the repository at this point in the history

  4. scripts/check-config: fix kernel version checks 

    Looking at the code, I found out that kernel_lt function was actually
doing le ("less than or equal") rather than lt ("less than") operation.
Let's fix this and do exactly what the name says.

A bigger issue is, the function use was not consistent (some uses
implied "less than or equal").

To fix the usage, find out all relevant kernel commits and kernel
versions that have them (the latter is done using "git describe
--contains $sha"), and fix the wrong cases. While at it, add references
to all these kernel commits for the future generations of
check-config.sh hackers.

Also, add kernel_ge function which is the opposite of kernel_lt,
and document both.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin
    kolyshkin committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d87366f View commit details
    Browse the repository at this point in the history

  5. script/check-config.sh: check CONFIG_BLK_CGROUP_IOCOST 

    For `io.weight`

Co-authored-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    @kolyshkin @AkihiroSuda
    kolyshkin and AkihiroSuda committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    5a4f521 View commit details
    Browse the repository at this point in the history