Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set the default value of CpuBurst to nil instead of 0 #4211

Merged
merged 2 commits into from
Apr 10, 2024
Merged

set the default value of CpuBurst to nil instead of 0 #4211

merged 2 commits into from
Apr 10, 2024

Commits on Apr 3, 2024

  1. add a test case for runc update cpu burst 

    In issue opencontainers#4210, if we don't provide `--cpu-burst` in `runc update`,
the value of cpu burst will always set to 0.

Signed-off-by: lifubang <lifubang@acmcoder.com>
    @lifubang
    lifubang committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    afcb9c2 View commit details
    Browse the repository at this point in the history

  2. runc update: distinguish nil from zero 

    Prior to this commit, commands like `runc update --cpuset-cpus=1`
were implying to set cpu burst to "0" (which does not mean "leave it as is").

This was failing when the kernel does not support cpu burst:
`openat2 /sys/fs/cgroup/runc-cgroups-integration-test/test-cgroup-22167/cpu.max.burst: no such file or directory`

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
    @AkihiroSuda @lifubang
    AkihiroSuda authored and lifubang committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    e4bf49f View commit details
    Browse the repository at this point in the history