Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcontainer: force apps to think fips is enabled/disabled for testing #4246

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

sohankunkerkar
Copy link
Contributor

The motivation behind this change is to provide a flexible mechanism for containers within a Kubernetes cluster to opt out of FIPS mode when necessary. This change enables apps to simulate FIPS mode being enabled or disabled for testing. Users can control whether apps believe FIPS mode is on or off by manipulating /proc/sys/crypto/fips_enabled.

The motivation behind this change is to provide a flexible mechanism for
containers within a Kubernetes cluster to opt out of FIPS mode when necessary.
This change enables apps to simulate FIPS mode being enabled or disabled for testing
purposes. Users can control whether apps believe FIPS mode is on or off by manipulating
`/proc/sys/crypto/fips_enabled`.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lifubang lifubang merged commit d0f803e into opencontainers:main Apr 12, 2024
38 checks passed
@sohankunkerkar sohankunkerkar deleted the runc-fips branch April 23, 2024 14:45
sohankunkerkar pushed a commit to sohankunkerkar/runc that referenced this pull request Apr 25, 2024
libcontainer: force apps to think fips is enabled/disabled for testing
@kolyshkin kolyshkin added the backport/done/1.1 A PR in main branch which was backported to release-1.1 label Apr 25, 2024
@lifubang lifubang mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/done/1.1 A PR in main branch which was backported to release-1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants