Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link to gvariant documentation in systemd docs. #4369

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Fix link to gvariant documentation in systemd docs. #4369

merged 1 commit into from
Aug 9, 2024

Conversation

TheSiman
Copy link
Contributor

@TheSiman TheSiman commented Aug 6, 2024

fixes #4368

rata
rata approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

btw, I don't think it is needed to create an issue, just the PR is enough. In fact, I'd prefer the PR to have more text than "fixes XX". But the commit has more text, so no need to change anything now.

@AkihiroSuda AkihiroSuda added the backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 label Aug 9, 2024
@AkihiroSuda AkihiroSuda merged commit 6602681 into opencontainers:main Aug 9, 2024
40 checks passed
@lifubang lifubang mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@rata rata rata approved these changes

Assignees
No one assigned
Labels
backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 easy-to-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix link to gvariant documentation in systemd docs.
3 participants
@TheSiman @rata @AkihiroSuda