Add gitcommit to runc builds #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcosnils i honestly have no clue what is going on in that thread. I think it's good to have to git version compiled into the runc binary so that you know the exact commit that it was built from. Its also very simple to do. And if people are building without git then they can build without our makefile as well |
|
if git errors out, use "local" instead? |
|
i guess we can just remove that part if there is no git, that maybe the best outcome for everyone? |
Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
crosbymichael
force-pushed
the
git-version
branch
from
10b4c86
to
beb3e5e
Compare
|
Ok, i changed it to exclude the commit information if it cannot be retrieved, i.e. you don't have git or the git checkout. |
|
@crosbymichael LGTM! |
|
@marcosnils thanks for the review |
|
LGTM |
1 similar comment
|
LGTM |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
[Config Solaris] Add anchor tags for headings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Crosby crosbymichael@gmail.com