Use '=' instead of ':' separator on labels #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y Docker Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
|
@rhatdan PTAL |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
@thaJeztah this must be reverted as well, as in, |
runcom
reviewed
Feb 6, 2017
| } | ||
|
|
||
| // DisableSecOpt returns a security opt that can be used to disabling SELinux | ||
| // labeling support for future container processes | ||
| func DisableSecOpt() []string { | ||
| return []string{"label:disable"} | ||
| return []string{"label=disable"} |
There was a problem hiding this comment.
this label= is docker specific, while here in libcontainer there shouldn't be any mention to docker. DisableSecOpt and DupSecOpt should just deal with disable,role,type,level. Both CRI-O and docker should just pass disable,role,type.level stuff and not label=....
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
…fg-link-target config-solaris: Restore 'zonecfg.1m_2' link targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Docker has deprecated ':' in moby/moby#21232
Triggered by moby/moby#22413