Skip to content

Commit

Permalink
Merge pull request #589 from wking/golint-requires-go-1.6
Browse files Browse the repository at this point in the history
Makefile: Require Go >= 1.6 for golint
  • Loading branch information
Mrunal Patel authored Oct 18, 2016
2 parents a39be46 + a9c0235 commit d6d6839
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ test: .govet .golint .gitvalidation

# `go get github.com/golang/lint/golint`
.golint:
ifeq ($(call ALLOWED_GO_VERSION,1.5,$(HOST_GOLANG_VERSION)),true)
ifeq ($(call ALLOWED_GO_VERSION,1.6,$(HOST_GOLANG_VERSION)),true)
@which golint > /dev/null 2>/dev/null || (echo "ERROR: golint not found. Consider 'make install.tools' target" && false)
golint ./...
endif
Expand All @@ -92,9 +92,9 @@ endif
.PHONY: install.tools
install.tools: .install.golint .install.gitvalidation

# golint does not even build for <go1.5
# golint does not even build for <go1.6
.install.golint:
ifeq ($(call ALLOWED_GO_VERSION,1.5,$(HOST_GOLANG_VERSION)),true)
ifeq ($(call ALLOWED_GO_VERSION,1.6,$(HOST_GOLANG_VERSION)),true)
go get -u github.com/golang/lint/golint
endif

Expand Down

0 comments on commit d6d6839

Please sign in to comment.