specs-go: export LinuxBlockIODevice #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously unexported linuxBlockIODevice prevented fully defined LinuxWeightDevice and LinuxThrottleDevice literals, making them less user-friendly than the rest of the interface. Signed-off-by: Antti Kervinen <antti.kervinen@intel.com>
askervin
force-pushed
the
5CD_export_linuxblockiodevice
branch
from
8b8ed4e
to
84251a4
Compare
tianon
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
LGTM
Tracing the history of this, I think it was originally made private by @vbatts, so maybe he can provide additional opinion (and review 🤓), but it appears the logic was because it's never used directly, and is rather only a shared ancestor for other types to avoid duplication.
|
haha tianon, i have no idea. Perhaps just erring on the side of make it
private unless required otherwise.
…On Mon, Apr 19, 2021 at 3:44 PM Tianon Gravi ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
Tracing the history of this, I think it was originally made private by
@vbatts <https://github.com/vbatts>, so maybe he can provide additional
opinion (and review 🤓), but it appears the logic was because it's never
used directly, and is rather only a shared ancestor for other types to
avoid duplication.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1103 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAQL2LJK6XYVYADU555BSDTJSB3FANCNFSM43BEFFTQ>
.
|
vbatts
approved these changes
Apr 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously unexported linuxBlockIODevice prevented fully defined
LinuxWeightDevice and LinuxThrottleDevice literals, making them
less user-friendly than the rest of the interface.
This solves issue #1067 (closed without a fix).