-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.2.0 #1242
Release v1.2.0 #1242
Conversation
6c897da
to
bb43699
Compare
3d3f131
to
70612ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ping @opencontainers/runtime-spec-maintainers |
Sorry, late to the party; I see various features being added; if we follow SemVer, should this increment the minor version, not the patch version? So v1.2.0 ? |
@thaJeztah Thanks for your comment. We haven't met the milestone for v1.2.0 yet. |
Hm, right, but we passed changes for a patch release, as there's features in the diff. SemVer is very clear on this; the version is baseed on the changes you're shipping, so you don't know the version "ahead of time". Is there a specific reason that milestone MUST be v1.2.0? Otherwise that milestone can become for v1.3.0. I think there's 3 options;
|
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@utam0k WDYT about renaming this to v1.2.0 ? |
I understand. I think it's good. I'll update it within a few days. |
70612ca
to
cfc1515
Compare
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
cfc1515
to
65cd1f8
Compare
@opencontainers/runtime-spec-maintainers I renamed this PR to v1.2.0. If you disagree, please cancel your vote. If you haven't done so already, please vote 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@cyphar ptal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🚀 It's time to release |
It's time we release the new patch version since we have met the milestone for
v1.1.1v1.2.0
https://github.com/opencontainers/runtime-spec/milestone/19
Previous release: #1213
Changes
Additions:
Minor fixes:
Documentation, CI & Governance:
[runtime-spec VOTE] tag 68346ed as v1.1.1
(at least 8 of 12 maintainers needed for this resolution to pass):