Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2.0 #1242

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Release v1.2.0 #1242

merged 2 commits into from
Feb 13, 2024

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Jan 5, 2024

It's time we release the new patch version since we have met the milestone for v1.1.1 v1.2.0
https://github.com/opencontainers/runtime-spec/milestone/19

Previous release: #1213

Changes

Additions:

Minor fixes:

Documentation, CI & Governance:


[runtime-spec VOTE] tag 68346ed as v1.1.1 (at least 8 of 12 maintainers needed for this resolution to pass):

ChangeLog Outdated Show resolved Hide resolved
specs-go/version.go Outdated Show resolved Hide resolved
@AkihiroSuda AkihiroSuda added this to the v1.1.1 milestone Jan 5, 2024
@utam0k utam0k requested a review from AkihiroSuda January 5, 2024 12:44
@utam0k utam0k force-pushed the proposal-v1.1.1 branch 2 times, most recently from 3d3f131 to 70612ca Compare January 5, 2024 12:56
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Member

ping @opencontainers/runtime-spec-maintainers

@thaJeztah
Copy link
Member

Sorry, late to the party; I see various features being added; if we follow SemVer, should this increment the minor version, not the patch version? So v1.2.0 ?

@utam0k
Copy link
Member Author

utam0k commented Jan 13, 2024

@thaJeztah Thanks for your comment. We haven't met the milestone for v1.2.0 yet.
https://github.com/opencontainers/runtime-spec/milestone/18

@thaJeztah
Copy link
Member

We haven't met the milestone for v1.2.0 yet.
https://github.com/opencontainers/runtime-spec/milestone/18

Hm, right, but we passed changes for a patch release, as there's features in the diff.

SemVer is very clear on this; the version is baseed on the changes you're shipping, so you don't know the version "ahead of time". Is there a specific reason that milestone MUST be v1.2.0? Otherwise that milestone can become for v1.3.0.

I think there's 3 options;

  1. if there's critical fixes merged that must be released; create a branch from the v1.1.0 tag, cherry-pick the fixes, and tag as v1.1.1
  2. do a regular release; follow SemVer, which means: determine the version based on the changes; tag as v1.2.0, and move the linked milestone to "v1.3.0"
  3. if there's a specific reason the next release MUST be v1.2.0; do a pre-release for ("v1.2.0-beta.1")

@AkihiroSuda
Copy link
Member

do a regular release; follow SemVer, which means: determine the version based on the changes; tag as v1.2.0, and move the linked milestone to "v1.3.0"

👍

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Member

@utam0k WDYT about renaming this to v1.2.0 ?

@utam0k
Copy link
Member Author

utam0k commented Jan 21, 2024

I understand. I think it's good. I'll update it within a few days.

@utam0k utam0k changed the title Release v1.1.1 Release v1.2.0 Jan 26, 2024
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
@utam0k
Copy link
Member Author

utam0k commented Jan 26, 2024

@opencontainers/runtime-spec-maintainers I renamed this PR to v1.2.0. If you disagree, please cancel your vote. If you haven't done so already, please vote 🙏

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrunalp
Copy link
Contributor

mrunalp commented Feb 12, 2024

@cyphar ptal.

Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@utam0k
Copy link
Member Author

utam0k commented Feb 13, 2024

🚀 It's time to release v1.2.0

@utam0k utam0k merged commit 88b8deb into opencontainers:main Feb 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants