version: more explicit version for comparison #173
Conversation
| const ( | ||
| // VersionMajor is for an API incompatible changes | ||
| VersionMajor = 0 | ||
| // VersionMinor is for functionality in a backwards-compatible manner |
There was a problem hiding this comment.
Maybe “VersionMinor is for backwards-compatible API changes”? And then mirror that for VersionMajor with “VersionMajor is for backwards-incompatible API changes”.
There was a problem hiding this comment.
this is leaning on verbiage from SemVer
There was a problem hiding this comment.
On Thu, Sep 10, 2015 at 12:32:25PM -0700, Vincent Batts wrote:
- // VersionMinor is for functionality in a backwards-compatible manner
this is leaning on verbiage from SemVer
Ah, consistency with semver.org is probably better than consistency
between the entries in this case. So suggestion retracted ;).
|
I don't know if this helps anything at this point. We should just make a note in the README that says: "During the 0.* series of OCI releases we make no backwards compatibility guarantees and intend to break the schema during this series." |
|
On Sep 10, 2015 3:48 PM, "Brandon Philips" notifications@github.com wrote:
Totally agree and was just fielding that response on irc |
For deterministic comparison and still providing a Version string for representation and reuse. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
As we ready for a draft release, verbiage is needed on what this pre-release means. Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
|
updated removed the test and added release verbiage |
|
On Thu, Sep 10, 2015 at 01:18:47PM -0700, Vincent Batts wrote:
Through d335ecd looks good to me. |
|
LGTM |
|
LGTM |
version: more explicit version for comparison
For deterministic comparison and still providing a Version string for
representation and reuse.
Signed-off-by: Vincent Batts vbatts@hashbangbash.com