-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct version from 0.1.0 to 0.1.1 #194
Conversation
On Wed, Sep 16, 2015 at 06:55:03PM -0700, LinZhinan(Zen Lin) wrote:
Duplicate of #183? I was suggesting we bump/tag 0.1.2 to avoid |
@wking, my suggestion is bumping to 0.1.2, guys maybe would like to consider the version is the same as de before one, anyway, once we have not release tag 0.1.2, the specs version should not be considered as 0.1.2. Now, we just release the tag v0.1.1, so we are better to keep consist with it. |
The tag object should reference to the commit which changed the version number. |
ping @vbatts |
lol. Cold medicine is crazy stuff, y'all. |
We can not change the tag, and nothing is strictly requiring this parity yet, and i'm not sure that there will be a need for a Like diff --git a/version.go b/version.go
index 3e722a5..d55f9b5 100644
--- a/version.go
+++ b/version.go
@@ -8,7 +8,7 @@ const (
// VersionMinor is for functionality in a backwards-compatible manner
VersionMinor = 1
// VersionPatch is for backwards-compatible bug fixes
- VersionPatch = 0
+ VersionPatch = 99
)
// Version is the specification version that the package types support. or diff --git a/version.go b/version.go
index 3e722a5..d984121 100644
--- a/version.go
+++ b/version.go
@@ -12,4 +12,4 @@ const (
)
// Version is the specification version that the package types support.
-var Version = fmt.Sprintf("%d.%d.%d", VersionMajor, VersionMinor, VersionPatch)
+var Version = fmt.Sprintf("%d.%d.%d-dev", VersionMajor, VersionMinor, VersionPatch) Personally, I prefer the former as it is strictly comparable and indicative of prerelease. |
On Mon, Sep 21, 2015 at 08:39:16AM -0700, Vincent Batts wrote:
I think the semver-2.0 phrasing for that would be 0.2.0-rc.1 or Hopefully our version cadence is fast enough that folks aren't tempted |
@zenlinTechnofreak lets just change the minor to |
I have made a err operations on closing this PR, but have created a new one for it, Thanks. |
Tag the thread about how we intend to version the spec. See additional version discussion in [1,2,3,4,5]. [1]: Subject: Re: Initial Draft Release Date: Fri, 11 Sep 2015 13:58:08 -0700 Message-ID: <20150911205808.GC5912@odin.tremily.us> [2]: opencontainers/runtime-spec#183 New v0.1.1 tag doesn't match v0.1.0 in version.go [3]: opencontainers/runtime-spec#253 Clarify backwards compatibility for major version 0 [4]: opencontainers/runtime-spec#194 Correct version from 0.1.0 to 0.1.1 [5]: opencontainers/runtime-spec#278 Project: document release process
Correct version from 0.1.0 to 0.1.1
Signed-off-by: LinZhinan(Zen Lin) linzhinan@huawei.com