Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify cwd #307

Merged
merged 2 commits into from
Jan 13, 2016
Merged

Clarify cwd #307

merged 2 commits into from
Jan 13, 2016

Conversation

vbatts
Copy link
Member

@vbatts vbatts commented Jan 13, 2016

carrying forward #286 by making the field required

laijs and others added 2 commits December 29, 2015 11:48
@laijs
define the default value for the cwd
df3f12d 
Signed-off-by: Lai Jiangshan <jiangshanlai@gmail.com>
@vbatts
config: cwd is a required default
25e6674 
After thorough discussion, even though a reasonable default is "/", for
platform independence, leave this up to the bundle author.

Also, by this variable being present it makes things explicit for the
runtime.

Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
@crosbymichael
Copy link
Member

LGTM

1 similar comment
@mrunalp
Copy link
Contributor

mrunalp commented Jan 13, 2016

LGTM

mrunalp pushed a commit that referenced this pull request Jan 13, 2016
Merge pull request #307 from vbatts/carry-cwd
d2617a1 
Clarify cwd
@mrunalp mrunalp merged commit d2617a1 into opencontainers:master Jan 13, 2016
@vbatts vbatts deleted the carry-cwd branch January 13, 2016 21:43
@wking
Copy link
Contributor

wking commented Jan 13, 2016

On Wed, Jan 13, 2016 at 01:41:00PM -0800, Vincent Batts wrote:

carrying forward #286 by making the field required

Should this have dropped omitempty from Process.Cwd in config.go?

Re 1, I think “different platforms have different defaults” is a
feature (platforms can try and differentiate themselves by picking
more useful defaults, and spec wording like 2 would ensure “runtimes
don't default to something different”). For an example where we
decided to expose platform defaults (as I think we should do
consistently), see 3.

@wking
Copy link
Contributor

wking commented Jan 13, 2016

On Wed, Jan 13, 2016 at 01:41:00PM -0800, Vincent Batts wrote:

  • config: cwd is a required default

I'm not sure what the plan is for maintaining the ChangeLog 1,
but if it's not “added right before cutting a release” we probably
don't want to wait too long before landing an entry for this
backwards-incompatible change.

@wking wking mentioned this pull request Jan 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vbatts @crosbymichael @mrunalp @wking @laijs