Move rlimits to process #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julian Friedman <julz.friedman@uk.ibm.com>
Signed-off-by: Julian Friedman <julz.friedman@uk.ibm.com>
|
|
||
| * **`capabilities`** (array of strings, optional) capabilities is an array that specifies Linux capabilities that can be provided to the process inside the container. | ||
| Valid values are the strings for capabilities defined in [the man page](http://man7.org/linux/man-pages/man7/capabilities.7.html) | ||
| * **`rlimits`** (array of rlimits, optional) rlimits is an array of rlimits that allows setting resource limits for a process inside the container. | ||
| The kernel enforces the `soft` limit for a resource while the `hard` limit acts as a ceiling for that value that could be set by an unprivileged process. | ||
| Valid values for the 'type' field are the resources defined in [the man page](http://man7.org/linux/man-pages/man2/setrlimit.2.html). |
There was a problem hiding this comment.
Backticks around type? And we may want to stick with the type style for all of these keys (including soft and hard).
|
LGTM |
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Mar 10, 2016
…rocess Move rlimits to process
|
We can update the formatting post merge |
vbatts
pushed a commit
to vbatts/oci-runtime-spec
that referenced
this pull request
Mar 10, 2016
Through 0bcb711 (Merge pull request opencontainers#341 2016-03-10). Signed-off-by: W. Trevor King <wking@tremily.us> Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
wking
referenced
this pull request
Apr 4, 2016
Also renamed "stop" to "delete" this way if we split it into stop & delete later on then delete is still pretty much the same. Signed-off-by: Doug Davis <dug@us.ibm.com>
Mashimiao
pushed a commit
to Mashimiao/specs
that referenced
this pull request
Aug 19, 2016
Through 0bcb711 (Merge pull request opencontainers#341 2016-03-10). Signed-off-by: W. Trevor King <wking@tremily.us> Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed at the 9/3/16 weekly call and on IRC, this moves the rlimits struct on to process to match capabilities, apparmor, selinux etc which were moved in 5a8a779.
Also fixed a typo (
systemd->systems)