Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReadMe] Just one level/tier of compliance (rebase) #553

Merged
merged 1 commit into from
Sep 6, 2016

Conversation

RobDolinMS
Copy link
Collaborator

Signed-off-by: Rob Dolin robdolin@microsoft.com

Signed-off-by: Rob Dolin <robdolin@microsoft.com>
@RobDolinMS
Copy link
Collaborator Author

This is a rebase of #543
/cc @wking @polvi @crosbymichael @mrunalp

An implementation is compliant for a given CPU architecture if it satisfies all the MUST and REQUIRED requirements for the protocols it implements.
An implementation that satisfies all the MUST or REQUIRED and all the SHOULD requirements for its protocols on a given CPU architecture is said to be "unconditionally compliant" with those protocols and architectures.
An implementation is not compliant for a given CPU architecture if it fails to satisfy one or more of the MUST, REQUIRED, or SHALL requirements for the protocols it implements.
An implementation is compliant for a given CPU architecture if it satisfies all the MUST, REQUIRED, and SHALL requirements for the protocols it implements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we saying the same thing twice, just backwards?
Also, why do we need to say "CPU architecture"? Why not just "An implementation is compliant if it ...." ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Thu, Sep 01, 2016 at 10:59:01AM -0700, Doug Davis wrote:

-An implementation is not compliant for a given CPU architecture if it fails to satisfy one or more of the MUST or REQUIRED requirements for the protocols it implements.
-An implementation is compliant for a given CPU architecture if it satisfies all the MUST and REQUIRED requirements for the protocols it implements.
-An implementation that satisfies all the MUST or REQUIRED and all the SHOULD requirements for its protocols on a given CPU architecture is said to be "unconditionally compliant" with those protocols and architectures.
+An implementation is not compliant for a given CPU architecture if it fails to satisfy one or more of the MUST, REQUIRED, or SHALL requirements for the protocols it implements.
+An implementation is compliant for a given CPU architecture if it satisfies all the MUST, REQUIRED, and SHALL requirements for the protocols it implements.

why are we saying the same thing twice, just backwards?

We could say:

An implementation is compliant for a given CPU architecture if and only if …

to reduce duplication, but without the “and only if” we need to say it
both ways.

Also, why do we need to say "CPU architecture"? Why not just "An
implementation is compliant if it ...." ?

Compliance is granted for a given architecture (more on this in #527).

@RobDolinMS
Copy link
Collaborator Author

@duglin Yes, lines 27 and 28 are similar.

@RobDolinMS
Copy link
Collaborator Author

@duglin I kept "CPU architecture" as it was added between my initial commit and this rebase and I wanted this change specifically focused on removing the two tiers/levels of compliance.

@vbatts
Copy link
Member

vbatts commented Sep 6, 2016

LGTM

Approved with PullApprove

1 similar comment
@crosbymichael
Copy link
Member

crosbymichael commented Sep 6, 2016

LGTM

Approved with PullApprove

@crosbymichael crosbymichael merged commit c678086 into opencontainers:master Sep 6, 2016
wking added a commit to wking/opencontainer-runtime-spec that referenced this pull request Sep 7, 2016
Through c678086 (Merge pull request opencontainers#553 from RobDolinMS/patch-11,
2016-09-06).

Signed-off-by: W. Trevor King <wking@tremily.us>
vbatts pushed a commit that referenced this pull request Sep 7, 2016
Through c678086 (Merge pull request #553 from RobDolinMS/patch-11,
2016-09-06).

Signed-off-by: W. Trevor King <wking@tremily.us>
vbatts pushed a commit that referenced this pull request Sep 7, 2016
Through c678086 (Merge pull request #553 from RobDolinMS/patch-11,
2016-09-06).

Signed-off-by: W. Trevor King <wking@tremily.us>
@RobDolinMS RobDolinMS deleted the patch-11 branch September 8, 2016 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants