specs-go/config: Drop "this field is platform dependent" #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These comments first landed in 820131d (*: flatten platform dependent source, 2016-03-08, opencontainers#310). But you can tell they're platform dependent by the platform:"..." tags. The Go comment doesn't add any additional information. Signed-off-by: W. Trevor King <wking@tremily.us>
|
LGTM (I am not a maintainer on this project) |
|
Fair |
|
LGTM, although there's at least one open PR that's adding more (which will need to be rebased 😄) |
|
On Thu, Sep 15, 2016 at 08:14:00AM -0700, Tianon Gravi wrote:
@jhowardmsft is on board [1,2] ;). |
wking
added a commit
to wking/opencontainer-runtime-spec
that referenced
this pull request
Sep 15, 2016
We dropped these in 4774080 (specs-go/config: Drop "this field is platform dependent", 2016-09-14, opencontainers#568) but f9e48e0 (Windows: User struct changes, 2016-09-14, opencontainers#565) was developed in parallel and brought in a new one. Signed-off-by: W. Trevor King <wking@tremily.us>
This was referenced Sep 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These comments first landed in 820131d (*: flatten platform dependent source, 2016-03-08, #310). But you can tell they're platform dependent by the platform:"..." tags. The Go comment doesn't add any additional information.
Spun off from #564.