specs-go/config: fix required items type #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
125b879 looks good to me. The associated JSON Schemas need
'required' entries for these fields as well, but that can happen in a
follow-up PR if you don't want to handle it here.
|
|
ping @opencontainers/runtime-spec-maintainers |
|
Looks fine to me, but doesn't this need a rebase after the aggressive namespacing patch? |
|
LGTM |
|
Needs rebase but why there is no conflict detect? |
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Mashimiao
force-pushed
the
specs-config-fix-required-type
branch
from
125b879
to
ef9ce84
Compare
|
rebased |
|
LGTM |
|
Ah, that's my fault... fixed. |
crosbymichael
requested changes
Oct 31, 2016
| @@ -300,7 +300,7 @@ type LinuxCPU struct { | |||
| // LinuxPids for Linux cgroup 'pids' resource management (Linux 4.3) | |||
| type LinuxPids struct { | |||
| // Maximum number of PIDs. Default is "no limit". | |||
| Limit *int64 `json:"limit,omitempty"` | |||
| Limit int64 `json:"limit"` | |||
There was a problem hiding this comment.
Isn't nil here meaning no limit?
There was a problem hiding this comment.
@crosbymichael, nil is not allowed because limit is required.
@stevvooe, I expect 0 should be illegal. Can you file a separate PR to require strictly positive value?
There was a problem hiding this comment.
From the kernel side, 0 is functionally identical to 1 (because you can join a cgroup even if it has a limit of 0).
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com
These items are defined as
required, I'm not sure the history, but I think they should not be pointer type.