Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid duplicated namespaces with same type. #597

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Forbid duplicated namespaces with same type. #597

merged 1 commit into from
Nov 1, 2016

Conversation

WeiZhang555
Copy link
Contributor

@WeiZhang555 WeiZhang555 commented Oct 27, 2016 •
edited
Loading

Related runc PR: opencontainers/runc#1150

Signed-off-by: Zhang Wei zhangwei555@huawei.com

@WeiZhang555
Forbid duplicated namespaces with same type.
c22eeb2 
Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
@wking wking mentioned this pull request Oct 27, 2016
Closed
@wking
Copy link
Contributor

wking commented Oct 27, 2016

Instead of using an array for a structure where order is insignificant
and duplicates are not allowed, I'd rather use an object (since the
just-landed #584, all of our objects forbid duplicates and do not have
significant ordering). I've filed #598 with that approach. I
understand that migrating from an array to an object will be painful,
but I think it's worth it if we have no reason to use arrays for
portable ordering or duplication. One benefit of using an object is
that we get much easier add-or-replace and removal code than hacks
like this 1.

@crosbymichael
Copy link
Member

crosbymichael commented Oct 27, 2016 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

1 similar comment
@hqhq
Copy link
Contributor

hqhq commented Nov 1, 2016 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@hqhq hqhq merged commit b8e2ebe into opencontainers:master Nov 1, 2016
hqhq added a commit to hqhq/runtime-spec that referenced this pull request Nov 3, 2016
@hqhq
Forbid duplicated rlimits with same type
6696846 
Alternative of opencontainers#583 , as what we do for `namespaces`
in opencontainers#597 .

Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
@hqhq hqhq mentioned this pull request Nov 3, 2016
Merged
@vbatts vbatts mentioned this pull request Dec 7, 2016
Merged
@wking wking mentioned this pull request Dec 21, 2016
Closed
@wking wking mentioned this pull request Dec 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WeiZhang555 @wking @crosbymichael @hqhq