Commits on Nov 4, 2016

1. config: Require absolute mount destinations …

   'destination' has been the path inside the container since c18c283
   (Change layout of mountpoints and mounts, 2015-09-02, opencontainers#136).  My
   personal preference is to have an explicit pivot root and allow paths
   relative to the current working directory [1], but that would be a big
   shift from the current OCI spec.  The only way the current spec lets
   you turn off the root pivot is by not setting a mount namespace at all
   (and even then, it's not clear if that turns off the pivot).  And the
   config's root entry is required (despite my attempts to have it made
   optional [2]), so it's not really clear how containers that don't set
   a mount namespace are supposed to work (if they're supported at all).
   
   You might be able to get away with something like:
   
     When a mount namespace is not set, destination paths are relative to
     the runtime's initial working directory (or relative to the
     config.json, or whatever).  When a mount namespace is set,
     destination paths are relative to the mount namespace's root.
   
   but with mount-namespace-less containers already so unclear, it seems
   better to just require absolute destinations.  If/when we get clearer
   support for explicit pivot-root calls or containers that inherit the
   host mount namespace (without re-joining it and losing their old
   working directory), we can consider lifting the absolute-path
   restriction.
   
   [1]: https://github.com/wking/ccon/tree/v0.4.0#mount-namespace
   [2]: https://groups.google.com/a/opencontainers.org/forum/#!topic/dev/6ZKMNWujDhU
        Date: Wed, 26 Aug 2015 12:54:47 -0700
        Subject: Dropping the rootfs requirement and restoring arbitrary bundle
          content
        Message-ID: <20150826195447.GX21585@odin.tremily.us>
   
   Signed-off-by: W. Trevor King <wking@tremily.us>

   

   wking committed Nov 4, 2016
   Configuration menu

   • View commit details
   • Copy full SHA for 40a5d98
   • Browse repository at this point

   Copy the full SHA

   40a5d98 View commit details

   Browse the repository at this point in the history