Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime] Add anchor tags for headings and bullets #614

Closed
wants to merge 2 commits into from

Conversation

RobDolinMS
Copy link
Collaborator

Signed-off-by: Rob Dolin robdolin@microsoft.com

Signed-off-by: Rob Dolin <robdolin@microsoft.com>
@cyphar
Copy link
Member

cyphar commented Nov 13, 2016

Is that syntax defined by the markdown spec? Because I would expect that it would result in you having lots of trailing <a> tags.

@wking
Copy link
Contributor

wking commented Nov 13, 2016

On Sat, Nov 12, 2016 at 06:03:32PM -0800, Aleksa Sarai wrote:

Is that syntax defined by the markdown spec?

From the spec 1:

For any markup that is not covered by Markdown’s syntax, you simply
use HTML itself…

Span-level HTML tags — e.g. , , or — can be used
anywhere in a Markdown paragraph, list item, or header. If you want,
you can even use HTML tags instead of Markdown formatting; e.g. if
you’d prefer to use HTML or tags instead of Markdown’s
link or image syntax, go right ahead.

So what @RobDolinMS has with e6fd589 is legal, although I'd prefer
moving to a markup language with better support for long-form docs
(#615).

@vbatts
Copy link
Member

vbatts commented Dec 14, 2016

needs a rebase

@RobDolinMS RobDolinMS mentioned this pull request Dec 24, 2016
11 tasks
@mrunalp mrunalp added this to the 1.0.0 milestone Jan 4, 2017
@mrunalp
Copy link
Contributor

mrunalp commented Jan 11, 2017

Needs rebase.

@crosbymichael
Copy link
Member

@RobDolinMS when you have time please rebase your PRs and make sure your sign off is correct. Feel free to reopen when they have been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants