Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Fix 'optional' -> 'OPTIONAL' for process.terminal #617

Merged
merged 1 commit into from
Nov 15, 2016
Merged

config: Fix 'optional' -> 'OPTIONAL' for process.terminal #617

merged 1 commit into from
Nov 15, 2016

Conversation

wking
Copy link
Contributor

@wking wking commented Nov 10, 2016

This happened in #574 but was accidentally rolled back in #518.

@wking
config: Fix 'optional' -> 'OPTIONAL' for process.terminal
458d998 
This happened in c35cf57 (config: Replace "optional" with "OPTIONAL",
2016-09-17, opencontainers#574) but was accidentally rolled back in 52f3cde
(Clarify wording for terminal setting and /dev/console, 2016-07-18,
opencontainers#518).

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking mentioned this pull request Nov 14, 2016
Merged
@mrunalp
Copy link
Contributor

mrunalp commented Nov 14, 2016 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

1 similar comment
@hqhq
Copy link
Contributor

hqhq commented Nov 15, 2016 •
edited by caniszczyk
Loading

LGTM

Approved with PullApprove

@hqhq hqhq merged commit b69dcba into opencontainers:master Nov 15, 2016
@wking wking deleted the process.terminal-optional-case branch November 16, 2016 05:26
@vbatts vbatts mentioned this pull request Dec 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wking @mrunalp @hqhq