-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename version
to ociVersion
according to runtime.md
#633
Conversation
4b30f38
to
41425b6
Compare
State
Root
and remove Status
in State
41425b6
to
a6b6507
Compare
I think status is included because this state object can be used as the output for |
Oh, my... I'm too confused now, it seems that we have many conflicts between specs and runc. runc containerState: https://github.com/opencontainers/runc/blob/master/list.go#L24-L41 specs description about container state: In my understanding, they should be the same, but currently they conflict with each other. conflicting fields include:
I'll try to make them synchronous, but the breaking of backward compatibility seems inevitable 😢 |
According to definition of [state](runtime.md#State), we should rename `version` field in `state.go` to `ociVersion` Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
a6b6507
to
c8f5a56
Compare
Update: only update Others:
Please take a look. @opencontainers/runc-maintainers @opencontainers/runtime-spec-maintainers |
Root
and remove Status
in State
version
to ociVersion
according to runtime.md
c8f5a56 looks good to me, and seems like a fairly straightforward
bugfix.
|
1 similar comment
Through d12da90 (Merge pull request opencontainers#633 from WeiZhang555/syncup-hook-state, 2016-12-06). Signed-off-by: W. Trevor King <wking@tremily.us>
Through d12da90 (Merge pull request opencontainers#633 from WeiZhang555/syncup-hook-state, 2016-12-06). Signed-off-by: W. Trevor King <wking@tremily.us>
Through d12da90 (Merge pull request opencontainers#633 from WeiZhang555/syncup-hook-state, 2016-12-06). Signed-off-by: W. Trevor King <wking@tremily.us>
Through d12da90 (Merge pull request opencontainers#633 from WeiZhang555/syncup-hook-state, 2016-12-06). Signed-off-by: W. Trevor King <wking@tremily.us>
Through d12da90 (Merge pull request opencontainers#633 from WeiZhang555/syncup-hook-state, 2016-12-06). Signed-off-by: W. Trevor King <wking@tremily.us>
* `Root` is path to the container's rootfs which can be useful information to hook, and the official sample runtime implementation--runc--has already added this field as payload to hook, we should add this to the spec.
Status
seems like unnecessary field, becauseState
is payload tohook and hook is executed in special time point, e.g.
Prestart
is a list of hooks to be run before the container process isexecuted, indicating a status of
created
.Poststart
is a list of hooks to be run immediately after the containerprocess is started, indicating a status of
running
.Poststop
is a list of hooks to be run after the container process exits,indicating a status of
stopped
.So the
Status
field is redundant.According to definition of state, we should rename
version
field instate.go
toociVersion
Signed-off-by: Zhang Wei zhangwei555@huawei.com