Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Fix config.md -> config.json typo #643

Merged
merged 1 commit into from
Dec 23, 2016

Conversation

wking
Copy link
Contributor

@wking wking commented Dec 7, 2016

Typo from #559.

From 766abd6 (runtime.md: Require 'create' to fail if config.json
asks for the impossible, 2016-09-08, opencontainers#559).

Signed-off-by: W. Trevor King <wking@tremily.us>
@mrunalp
Copy link
Contributor

mrunalp commented Dec 7, 2016

LGTM

Approved with PullApprove

@@ -87,7 +87,7 @@ This operation MUST generate an error if it is not provided a path to the bundle
If the ID provided is not unique across all containers within the scope of the runtime, or is not valid in any other way, the implementation MUST generate an error and a new container MUST NOT be created.
Using the data in [`config.json`](config.md), this operation MUST create a new container.
This means that all of the resources associated with the container MUST be created, however, the user-specified program MUST NOT be run at this time.
If the runtime cannot create the container as specified in [`config.md`](config.md), it MUST generate an error and a new container MUST NOT be created.
If the runtime cannot create the container as specified in [`config.json`](config.md), it MUST generate an error and a new container MUST NOT be created.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the (config.md) in the same line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a Markdown link target, so folks can see the spec behind config.json.

@dqminh
Copy link
Contributor

dqminh commented Dec 7, 2016

LGTM

Approved with PullApprove

1 similar comment
@hqhq
Copy link
Contributor

hqhq commented Dec 23, 2016

LGTM

Approved with PullApprove

@hqhq hqhq merged commit 2b22402 into opencontainers:master Dec 23, 2016
@wking wking deleted the runtime-config.md-typo branch January 6, 2017 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants