Add gVisor to the implementations list #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
reviewed
May 18, 2018
implementations.md
Outdated
| @@ -13,6 +13,7 @@ If you know of any associated projects that are not listed here, please file a p | |||
|
|
|||
| * [hyperhq/runv][runv] - Hypervisor-based runtime for OCI | |||
| * [clearcontainers/runtime][cc-runtime] - Hypervisor-based OCI runtime utilising [virtcontainers][virtcontainers] by Intel®. | |||
| * [google/gvisor][gvisor] - gVisor is a user-space kernel, contains runsc to run sandboxed containers] | |||
There was a problem hiding this comment.
last square bracket at the end of the line seems unnecessary
There was a problem hiding this comment.
thanks, sigh, fixed
Signed-off-by: Chris Aniszczyk <caniszczyk@gmail.com>
|
LGTM |
1 similar comment
|
LGTM |
|
Can someone with write access delete this branch now that the PR is merged? |
|
Branches on origin; naughty @caniszczyk 😂 |
|
sorry looks all good now :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also add gvisor to the list, although not sure where to put it.
https://github.com/google/gvisor
Signed-off-by: Chris Aniszczyk caniszczyk@gmail.com