Merge pull request #76 from Mashimiao/runtime-test-readonly-path-vali…

…dation runtimetest: add readonly path validation
opencontainers · Jun 2, 2016 · 89907b6 · 89907b6
2 parents 5e5e247 + 447a73b
commit 89907b6
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/cmd/runtimetest/main.go b/cmd/runtimetest/main.go
@@ -233,6 +233,17 @@ func validateMaskedPaths(spec *rspec.Spec) error {
 	return nil
 }
 
+func validateROPaths(spec *rspec.Spec) error {
+	fmt.Println("validating readonlyPaths")
+	for _, v := range spec.Linux.ReadonlyPaths {
+		err := testWriteAccess(v)
+		if err == nil {
+			return fmt.Errorf("%v should be readonly", v)
+		}
+	}
+	return nil
+}
+
 func main() {
 	spec, err := loadSpecConfig()
 	if err != nil {
@@ -247,6 +258,7 @@ func main() {
 		validateRlimits,
 		validateSysctls,
 		validateMaskedPaths,
+		validateROPaths,
 	}
 
 	for _, v := range validations {