Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completions: update based on generate help message #167

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions completions/bash/ocitools
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ _ocitools_generate() {
--cap-add
--cap-drop
--cgroup
--cgroup-path
--cwd
--env
--gid
Expand All @@ -283,25 +284,31 @@ _ocitools_generate() {
--hostname
--help
--ipc
--label
--mount
--mount-cgroups
--mount-label
--network
--os
--output
--pid
--poststart
--poststop
--prestart
--root-propagation
--rootfs
--seccomp-default
--seccomp-allow
--seccomp-arch
--seccomp-default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would want completions for this since it is possible.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrunalp Sorry, I don't get it. You mean I should not change its order or I should remove it?

--seccomp-errno
--seccomp-syscalls
--selinux-label
--mount-label
--sysctl
--tmplate
--tmpfs
--uid
--uidmappings
--user
--uts
"

Expand Down Expand Up @@ -330,11 +337,6 @@ _ocitools_generate() {
return
;;

--seccomp-default)
__ocitools_complete_seccomp_actions
return
;;

--root-propagation)
__ocitools_complete_propagations
return
Expand Down