update urfave/cli package #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrunalp , PTAL. |
| "Comment": "v1.17.0-57-gedb24d0", | ||
| "Rev": "edb24d02aa3cea2319c33f2836d4a5133907fe4c" | ||
| "Comment": "v1.18.0-47-g168c954", | ||
| "Rev": "168c95418e66e019fe17b8f4f5c45aa62ff80e23" |
There was a problem hiding this comment.
Can we bump this to v1.18.0 on the nose (urfave/cli@1efa31f)? It includes the features you want.
There was a problem hiding this comment.
@wking , no problem. Fixed it. Thanks. PTAL.
The new version of urfave/cli supports Int64Flag and Uint64Flag. These flag types are useful for setting cpu/mem resources. Signed-off-by: Haiyan Meng <hmeng@redhat.com>
|
LGTM |
|
dc3404e looks good to me.
|
wking
pushed a commit
to wking/ocitools-v2
that referenced
this pull request
Aug 3, 2016
The new version of urfave/cli supports Int64Flag and Uint64Flag. These flag types are useful for setting cpu/mem resources. Signed-off-by: Haiyan Meng <hmeng@redhat.com> Backported to v1.0.0.rc1 from dc3404e opencontainers#174 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haiyan Meng hmeng@redhat.com