Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add runtime-spec initial maintainers #239

Merged
merged 1 commit into from
Oct 13, 2016

Conversation

liangchenye
Copy link
Member

#238 #237

Signed-off-by: liang chenye liangchenye@huawei.com

@liangchenye
Copy link
Member Author

PTAL @mrunalp @Mashimiao @wking @caniszczyk

@wking
Copy link
Contributor

wking commented Oct 13, 2016

How I expected this to work in the wake of opencontainers/tob#18 was:

  1. One PR to update the local MAINTAINERS file to match runtime-spec.
    This doesn't need any local LGTMs because it has already been voted
    on by the TOB 1.
  2. A follow-up PR or two to add @liangchenye and @Mashimiao. These
    need ⅔ votes of whoever happens to be in MAINTAINERS at the time,
    with a “five business days” period 2. Although I don't think
    that five-day limit is particularly serious, and was certainly not
    met by MAINTAINERS: add Aleksa Sarai to maintainers runc#503 which was open for almost three
    months.

Can we make this PR just about (1)?

 Subject: Re: [oci-tob] Re: VOTE Required: approve new projects: image-tools, runtime-tools
 Date: Wed, 14 Sep 2016 17:48:33 +0000
 Message-ID: <CAD2oYtO_4Ghf5hJ04fDXHqCF8-oyDEQ_8wKC5Rcgcbh+M0kBrw@mail.gmail.com>

Signed-off-by: liang chenye <liangchenye@huawei.com>
@liangchenye liangchenye changed the title add runtime-spec maintainers and mashimiao add runtime-spec initial maintainers Oct 13, 2016
@liangchenye
Copy link
Member Author

@wking Changed

@wking
Copy link
Contributor

wking commented Oct 13, 2016 via email

@mrunalp
Copy link
Contributor

mrunalp commented Oct 13, 2016

LGTM

@mrunalp mrunalp merged commit 6601714 into opencontainers:master Oct 13, 2016
@wking
Copy link
Contributor

wking commented Oct 14, 2016

On Thu, Oct 13, 2016 at 12:07:44PM -0700, Mrunal Patel wrote:

Merged #239.

The runtime-tools-maintainers group should be updated to reflect this
change so folks don't have to use runtime-spec-maintainers 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants