add bundle validate, using reflect to check omitempty #4

liangchenye · 2016-01-21T01:06:58Z

Signed-off-by: Liang Chenye liangchenye@huawei.com

Based on previous PR (mrunalp/ocitools#10).

correct rootfs reading problem
way to try it:
make a bundle 'testbundle for example' by ocitools generate & tar xzvf rootfs.tar.gz
ocitools bvalidate --path=testbundle
add 'reflect' to check 'omitempty' in spec/*go file
open it once spec version in Godeps updated with opencontainer/specs

Signed-off-by: Liang Chenye <liangchenye@huawei.com>

mrunalp · 2016-01-22T19:29:33Z

bvalidate.go

+			logrus.Fatal(err)
+		} else {
+			if spec.Platform.OS != "linux" {
+				logrus.Fatalf("Operation system '%s' of the bundle is not support yet.", spec.Platform.OS)


s/support/supported/

Signed-off-by: Liang Chenye <liangchenye@huawei.com>

liangchenye · 2016-01-24T13:46:10Z

Replace original validate.go with new one (bvalidate.go).

@mrunalp @zenlinTechnofreak
so runtimevalidate will not be a sub-command but a test framework, right?

zenlint · 2016-01-25T00:56:49Z

@liangchenye @mrunalp I think if we named bundle validation tool as validateCommand of ocitool, the only way to push runtime validation tool into the repo is to create a seperate main programme from ocitool, no matter it is a framework or not.

If in that way, I should rebase my PR 'Add initial version of runtimetest command: #9' to a seperate tool, but not a sub command.

What is your design in the ocitools repo? It should be nice if you can let me know. Thanks very much.

liangchenye · 2016-01-26T10:23:16Z

@zenlinTechnofreak my opinion is we should provides three official sub-command in ocitools.

generate
-- generate bundle according to user's input
bundle validate
-- validate if a bundle is valid
once the 'layered' bundle released, more validating codes will needed.
runtime validate
-- validate if a runtime is valid
pass all the test cases you provided.
it is very similar to test_runtime.sh, the original requirement is Convert test_runtime.sh into a go program mrunalp/ocitools#8

Other command/program/script like get-stage3.sh is important, but maybe suitable to put into a 'contrib' directory. @wking

wking · 2016-01-26T17:30:05Z

On Tue, Jan 26, 2016 at 02:23:16AM -0800, 梁辰晔 (Liang Chenye) wrote:

Other command/program/script like get-stage3.sh is important, but
maybe suitable to put into a 'contrib' directory. @wking

get-stage3.sh is certainly internal tooling and not part of this
package's public interface. Feel free to put it wherever you like ;).

mrunalp · 2016-01-26T23:25:43Z

@liangchenye Yes, having these 3 commands makes sense.

ChengTiesheng · 2016-01-27T01:53:43Z

@liangchenye @zenlinTechnofreak @mrunalp @wking, a more command maybe needed: oci convert, which converts oci bundle to other container images(e.g. docker image or ACI image), any thoughts?

wking · 2016-01-27T05:31:06Z

On Tue, Jan 26, 2016 at 05:53:44PM -0800, Tiesheng wrote:

oci convert, which converts oci bundle to other container
images(e.g. docker image or ACI image), any thoughts?

Conversions like that are going to be complicated and lossy (at least
in one direction, it seems unlikely that the feature sets are
identical for two tools). I'd rather keep conversion tools like that
in different repositories to cut down on noise in the
conformance-testing tool. But I agree that those tools will be
useful, so +1 to putting them under opencontainers/ if you can attract
enough OCI-member support for them.

liangchenye · 2016-01-27T08:22:28Z

@ChengTiesheng I'll create a new PR to add 'contrib' directory.
The convert tools could be add to that directory.

Signed-off-by: liangchenye <liangchenye@huawei.com>

liangchenye · 2016-01-27T09:25:00Z

Use bundleValidateCommand (bvalidate) as the sub-command.

@zenlinTechnofreak maybe you can use
runtimeValidateCommand(rvalidate) as another sub-command to do the runtime test.

Signed-off-by: liangchenye <liangchenye@huawei.com>

add contrib directory and mv get-stage3 to that

Signed-off-by: liangchenye <liangchenye@huawei.com>

@wking

To verify the changes in opencontainers#4, I intentionally broke Diagnostic() by prefixing lines with "!" instead of "#" but the tests still passed. The spec[1] allows a test harness to silently ignore lines it doesn't understand, so that behavior makes sense. Red light green light testing[2] requires that our test be capable of failing if something is broken. This commit adds that by comparing the actual output against our expected output. Hat tip to @wking for suggesting to compare output[3]. 1: http://testanything.org/tap-version-13-specification.html#anything-else 2: http://stackoverflow.com/a/404860/174463 3: mndrix/tap-go#4 (comment)

Now that we have a function to generate diagnostic output, we don't have to construct it manually. See opencontainers#4

@wking

To verify the changes in opencontainers#4, I intentionally broke Diagnostic() by prefixing lines with "!" instead of "#" but the tests still passed. The spec[1] allows a test harness to silently ignore lines it doesn't understand, so that behavior makes sense. Red light green light testing[2] requires that our test be capable of failing if something is broken. This commit adds that by comparing the actual output against our expected output. Hat tip to @wking for suggesting to compare output[3]. 1: http://testanything.org/tap-version-13-specification.html#anything-else 2: http://stackoverflow.com/a/404860/174463 3: mndrix/tap-go#4 (comment)

Now that we have a function to generate diagnostic output, we don't have to construct it manually. See opencontainers#4

add bundle validate, using reflect to check omitempty

667f2e1

Signed-off-by: Liang Chenye <liangchenye@huawei.com>

mrunalp reviewed Jan 22, 2016
View reviewed changes

mrunalp mentioned this pull request Jan 22, 2016

Remove unused code for validation #14

Merged

liangchenye added 5 commits January 24, 2016 05:00

fix message typo; replace validate by bvalidate

1f40975

Signed-off-by: Liang Chenye <liangchenye@huawei.com>

add validate to README.md

92bda88

Signed-off-by: Liang Chenye <liangchenye@huawei.com>

fix tab in README.md

2d277db

Signed-off-by: Liang Chenye <liangchenye@huawei.com>

merge bundle validate with upstream

73f69bf

Signed-off-by: Liang Chenye <liangchenye@huawei.com>

conflict merge REAME.md

bc8cb89

Signed-off-by: Liang Chenye <liangchenye@huawei.com>

add contrib directory and mv get-stage3 to that

1697953

Signed-off-by: liangchenye <liangchenye@huawei.com>

liangchenye mentioned this pull request Jan 27, 2016

add contrib directory and mv get-stage3 to that #17

Merged

change back to bundleValidateCommand

fee7a5c

Signed-off-by: liangchenye <liangchenye@huawei.com>

rename to rootfs-builder

607ee90

Signed-off-by: liangchenye <liangchenye@huawei.com>

wking mentioned this pull request Jan 29, 2016

Add convert tools as the sub command of ocitools #18

Closed

Mrunal Patel and others added 2 commits February 5, 2016 10:54

Merge pull request #17 from liangchenye/contrib

0ad2df8

add contrib directory and mv get-stage3 to that

add bundle validate as sub-command

50ada03

Signed-off-by: liangchenye <liangchenye@huawei.com>

liangchenye closed this Feb 5, 2016

liangchenye deleted the bundle branch February 5, 2016 09:40

liangchenye mentioned this pull request Feb 5, 2016

add bundle validate as sub-command #20

Merged

fmuyassarov pushed a commit to fmuyassarov/runtime-tools that referenced this pull request May 4, 2023

Use Diagnostic() inside Check()

53c5e22

Now that we have a function to generate diagnostic output, we don't have to construct it manually. See opencontainers#4

fmuyassarov pushed a commit to fmuyassarov/runtime-tools that referenced this pull request May 4, 2023

Use Diagnostic() inside Check()

324f6e5

Now that we have a function to generate diagnostic output, we don't have to construct it manually. See opencontainers#4

fmuyassarov pushed a commit to fmuyassarov/runtime-tools that referenced this pull request May 6, 2023

Use Diagnostic() inside Check()

19f6898

Now that we have a function to generate diagnostic output, we don't have to construct it manually. See opencontainers#4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add bundle validate, using reflect to check omitempty #4

add bundle validate, using reflect to check omitempty #4

liangchenye commented Jan 21, 2016

mrunalp Jan 22, 2016

liangchenye commented Jan 24, 2016

zenlint commented Jan 25, 2016

liangchenye commented Jan 26, 2016

wking commented Jan 26, 2016

mrunalp commented Jan 26, 2016

ChengTiesheng commented Jan 27, 2016

wking commented Jan 27, 2016

liangchenye commented Jan 27, 2016

liangchenye commented Jan 27, 2016

add bundle validate, using reflect to check omitempty #4

add bundle validate, using reflect to check omitempty #4

Conversation

liangchenye commented Jan 21, 2016

mrunalp Jan 22, 2016

Choose a reason for hiding this comment

liangchenye commented Jan 24, 2016

zenlint commented Jan 25, 2016

liangchenye commented Jan 26, 2016

wking commented Jan 26, 2016

mrunalp commented Jan 26, 2016

ChengTiesheng commented Jan 27, 2016

wking commented Jan 27, 2016

liangchenye commented Jan 27, 2016

liangchenye commented Jan 27, 2016