Bump gojsonschema #733
Merged
Bump gojsonschema #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New(er) xeipuuv/gojsonschema package is trying to fetch id fields, which in the spec were looking like this: "id": "https://opencontainers.org/schema/bundle/linux" Obviously, this results in HTTP 404s, and multiple test failures. This was fixed by opencontainers/runtime-spec#945 which ended up in runtime-spec v1.0.2. This essentially means with newer xeipuuv/gojsonschema we are no longer able to validate against runtime-spec < 1.0.2. To adopt for a new xeipuuv/gojsonschema, do the following: 1. Add the version check, add a test case for it. 2. Remove some test cases: - "process is required" as it needed v1.0.0-rc5 version of spec. - "args is required" as args are no longer required since commit opencontainers/runtime-spec@deb4d954eafc4fc. 3. Bump the spec version in all test cases. 4. Fix "invalid seccomp action" error as it now also has SCMP_ACT_LOG. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Brought to you by go get github.com/xeipuuv/gojsonschema@latest go mod vendor go mod tidy Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
LGTM |
tianon
approved these changes
Oct 25, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate: fix tests for new xeipuuv/gojsonschema
New(er) xeipuuv/gojsonschema package is trying to fetch id fields,
which in the spec were looking like this:
Obviously, this results in HTTP 404s, and multiple test failures.
This was fixed by schema: Completely drop our JSON Schema 'id' properties runtime-spec#945
which ended up in runtime-spec v1.0.2.
able to validate against runtime-spec < 1.0.2.
To adopt for a new xeipuuv/gojsonschema, do the following:
Add the version check, add a test case for it.
Remove some test cases:
opencontainers/runtime-spec@deb4d954eafc4fc.
Bump the spec version in all test cases.
Fix "invalid seccomp action" error as it now also has SCMP_ACT_LOG.
deps: bump github.com/xeipuuv/gojsonschema to v1.2.0
Brought to you by