Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: expand CAS blob verification #278

Closed
cyphar opened this issue Nov 13, 2018 · 1 comment
Closed

security: expand CAS blob verification #278

cyphar opened this issue Nov 13, 2018 · 1 comment

Comments

@cyphar
Copy link
Member

cyphar commented Nov 13, 2018

Currently we verify that layer hashes match (against the DiffID), but it's probably a good idea that we also verify that the CAS blobs all are correct. We can probably do this by wrapping the returned blob with a verifier that returns an error on EOF if the digest is mismatched (though we'd have to make sure our Close calls as well as any io.Copy errors are all correctly checked).

@cyphar
Copy link
Member Author

cyphar commented Dec 26, 2018

This slightly depends on a change within #280.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant