ci: add more checks #280
Merged
ci: add more checks #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksa Sarai <asarai@suse.de>
After doing an audit of the source with gosec, we now check all errors explicitly -- with #nosec labels added where it is appropriate (G104 is the error type for unhandled errors). We don't care about G301, G302, or G304 because they simply have too much noise. Signed-off-by: Aleksa Sarai <asarai@suse.de>
Signed-off-by: Aleksa Sarai <asarai@suse.de>
cyphar
force-pushed
the
ci-go-mod-vendor
branch
from
142f012
to
82b8945
Compare
Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's necessary to add CI checks for gosec as well as
go mod vendorsanity.Signed-off-by: Aleksa Sarai asarai@suse.de