cmd: add support for --clear=config.{cmd,entrypoint} #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the current UX for --config.cmd and --config.entrypoint seems odd (since they aren't treated atomically, which doesn't make any sense). But since we're currently treating them like ENV we need to provide a way to explicitly clear them (even though we clear the old value when creating a new one). Reported-by: David Cassany <dcassany@suse.com> Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
/cc @davidcassany |
Signed-off-by: Aleksa Sarai <asarai@suse.de>
cyphar
force-pushed
the
add-clear-cmd-entrypoint
branch
2 times, most recently
from
0322a48
to
6ee1b85
Compare
Signed-off-by: Aleksa Sarai <asarai@suse.de>
cyphar
force-pushed
the
add-clear-cmd-entrypoint
branch
from
6ee1b85
to
2a596ae
Compare
|
Looks good to me, thanks! However I could not try it, apparently I do not have the appropriate tool chain for compiling it 😛 |
|
You shouldn't need anything more than |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the current UX for --config.cmd and --config.entrypoint seems odd
(since they aren't treated atomically, which doesn't make any sense).
But since we're currently treating them like ENV we need to provide a
way to explicitly clear them (even though we clear the old value when
creating a new one).
Reported-by: David Cassany dcassany@suse.com
Signed-off-by: Aleksa Sarai asarai@suse.de