Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpack: don't set AdditionalGids in rootless mode #109

Merged
merged 1 commit into from
Apr 9, 2017

Conversation

cyphar
Copy link
Member

@cyphar cyphar commented Apr 7, 2017

We can't join any additional groups as an unprivileged user, so
retaining these groups will always cause failures.

I found this while working on cyphar/orca-build#6.

Signed-off-by: Aleksa Sarai asarai@suse.de

@cyphar cyphar force-pushed the rootless-no-additional-gids branch 2 times, most recently from a2c5217 to fa78fc4 Compare April 9, 2017 15:26
We can't join any additional groups as an unprivileged user, so
retaining these groups will always cause failures.

Signed-off-by: Aleksa Sarai <asarai@suse.de>
@cyphar cyphar force-pushed the rootless-no-additional-gids branch from fa78fc4 to 7d4c24b Compare April 9, 2017 16:02
@cyphar
Copy link
Member Author

cyphar commented Apr 9, 2017

LGTM

@cyphar cyphar merged commit 7d4c24b into master Apr 9, 2017
cyphar referenced this pull request Apr 9, 2017
LGTMs: @cyphar
Closes openSUSE/umoci#109
@cyphar cyphar deleted the rootless-no-additional-gids branch April 9, 2017 17:12
@cyphar cyphar added this to the 0.2.0 milestone Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant