cmd: umoci: add umoci-raw-runtime-config(1) #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
force-pushed
the
cmd-raw-config
branch
2 times, most recently
from
324067a
to
9edbbf5
Compare
cyphar
force-pushed
the
cmd-raw-config
branch
4 times, most recently
from
472f37c
to
96b597f
Compare
Make UnpackManifest a bit less monolithic, though this code really needs a stream cleaning. This is in preparation of umoci-raw-config(1). Signed-off-by: Aleksa Sarai <asarai@suse.de>
If the Config.User string is numeric then this isn't an issue, however we need to return defaults if Config.User is some user and we haven't provided a rootfs. This is going to be required for umoci-raw-config(1) to work nicely. Signed-off-by: Aleksa Sarai <asarai@suse.de>
Add a new command to allows users that have to parse the generated config.json often much more efficient (by allowing them to skip the layer unpacking steps). Since the output of this command is not quite obvious unless you know what it's doing, hide it behind a "raw" subcommand that should scare away users that don't know enough about the OCI specs. Signed-off-by: Aleksa Sarai <asarai@suse.de>
These tests are basically a clone of the umoci-config(1) tests, but using just umoci-raw-runtime-config(1) to generate the config.json. Signed-off-by: Aleksa Sarai <asarai@suse.de>
Signed-off-by: Aleksa Sarai <asarai@suse.de>
Signed-off-by: Aleksa Sarai <asarai@suse.de>
The old system of symlinks was bad and kept breaking quite often, so switch to symlinking the sources not the results. In addition, clean up some of the overly-liberal usage of []. Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new command to allows users that have to parse the generated
config.json often much more efficient (by allowing them to skip the
layer unpacking steps).
Since the output of this command is not quite obvious unless you know
what it's doing, hide it behind a "raw" subcommand that should scare
away users that don't know enough about the OCI specs.
Implements #21
Signed-off-by: Aleksa Sarai asarai@suse.de