*: rework validation scripts #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksa Sarai <asarai@suse.de>
cyphar
force-pushed
the
rework-validation
branch
9 times, most recently
from
cbcc821
to
00e1a81
Compare
This is necessary in order to avoid go-vet warnings, as well as removing
the ugly Engine{engine} interface. In future, the implementation of
casext.Engine will be made private and casext.Engine will be an
interface.
Signed-off-by: Aleksa Sarai <asarai@suse.de>
It appears that local-validate has not been running in recent PRs. Fix this by reworking `make ci` and the travis configuration to make sure it runs. In addition, this un-comments git-validation which has resolved their issues with running in Travis. Signed-off-by: Aleksa Sarai <asarai@suse.de>
Signed-off-by: Aleksa Sarai <asarai@suse.de>
cyphar
force-pushed
the
rework-validation
branch
from
00e1a81
to
0b4bec4
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that local-validate has not been running in recent PRs. Fix
this by reworking
make ciand the travis configuration to make sure itruns. This is critical for CII bading.
In addition, this un-comments git-validation which has resolved their
issues with running in Travis.
Signed-off-by: Aleksa Sarai asarai@suse.de