repack: change --[ug]id-map= UX to match user_namespaces(7) #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
force-pushed
the
idmap-fix-format
branch
from
d780bda
to
8b5d434
Compare
Our IDMap interfaces were not matching what a user who is familiar with user_namespaces(7) would expect. This caused me some confusion while trying to debug a user namespace bug. While this is a breaking change, I'm fairly confident that there are almost no users of this feature. In addition, actually add documentation on the --[ug]id-map format (which was previously not explicitly documented at all). Fixes: 9f88dd9 ("{un,re}pack: implement ID mapping") Signed-off-by: Aleksa Sarai <asarai@suse.de>
Signed-off-by: Aleksa Sarai <asarai@suse.de>
cyphar
force-pushed
the
idmap-fix-format
branch
from
8b5d434
to
89b63f1
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our IDMap interfaces were not matching what a user who is familiar with
user_namespaces(7) would expect. This caused me some confusion while
trying to debug a user namespace bug. While this is a breaking change,
I'm fairly confident that there are almost no users of this feature.
In addition, actually add documentation on the --[ug]id-map format
(which was previously not explicitly documented at all).
Fixes: 9f88dd9 ("{un,re}pack: implement ID mapping")
Signed-off-by: Aleksa Sarai asarai@suse.de