Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: system: use Major, Minor and Mkdev from x/sys/unix #194

Merged
merged 2 commits into from
Oct 17, 2017
Merged

pkg: system: use Major, Minor and Mkdev from x/sys/unix #194

merged 2 commits into from
Oct 17, 2017

Conversation

tklauser
Copy link
Contributor

As suggested by @cyphar in opencontainers/runc#1614 😉

  • re-vendor golang.org/x/sys to get Major, Minor and Mkdev
  • use these functions in pkg/system

@tklauser
vendor: add golang.org/x/sys@686000749eaec0b8855b8eef5336cf63899fe51d
ba80c2e 
Re-vendor golang.org/x/sys in order to get the newly added
Major, Minor and Mkdev functions.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser
pkg: system: use Major, Minor and Mkdev from x/sys/unix
7220123 
Use these functions from golang.org/x/sys instead of re-implementing
them.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser mentioned this pull request Oct 17, 2017
Merged
@cyphar
Copy link
Member

cyphar commented Oct 17, 2017 •
edited
Loading

LGTM.

😸 Thanks!

@cyphar cyphar merged commit 7220123 into opencontainers:master Oct 17, 2017
cyphar added a commit that referenced this pull request Oct 17, 2017
@cyphar
merge branch 'pr-194'
07263d2 
  pkg: system: use Major, Minor and Mkdev from x/sys/unix
  vendor: add golang.org/x/sys@686000749eaec0b8855b8eef5336cf63899fe51d

LGTMs: @cyphar
Closes #194
@tklauser tklauser deleted the device-numbers branch October 18, 2017 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tklauser @cyphar