*: clean some old deprecated comments #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
reviewed
Oct 24, 2017
| # version of go-mtree. It's a feature I implemented in the library for | ||
| # umoci's support, and is currently being proposed in | ||
| # https://github.com/vbatts/go-mtree/pull/96. I would not hold my breath | ||
| # that it'll be merged any time soon. |
There was a problem hiding this comment.
This comment is inaccurate, but it is still true that -rootless is an (open)SUSE extension to gomtree. The linked PR has changed since I wrote the commend, and it just adds an FsEval interface to all of the key methods -- but the integration with umoci's pkg/unpriv is still out-of-tree.
There was a problem hiding this comment.
oops, misread. Updated..
There were various references to patched versions of go-mtree, but all mentioned fixes are now in the upstream version that umoci is using. Signed-off-by: Jonathan Boulle <jonathanboulle@gmail.com>
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were various references to patched versions of go-mtree, but all
mentioned fixes are now in the upstream version that umoci is using.
Signed-off-by: Jonathan Boulle jonathanboulle@gmail.com