Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umoci: add --tag to umoci-insert #273

Merged
merged 1 commit into from
Nov 11, 2018

Conversation

cyphar
Copy link
Member

@cyphar cyphar commented Nov 11, 2018

Before this there was no way to make --tag non-destructive, so we just
copy the semantics from umoci-config. This won't break existing scripts
because the default is still to override (just like it is with
umoci-config).

Signed-off-by: Aleksa Sarai asarai@suse.de

@cyphar
Copy link
Member Author

cyphar commented Nov 11, 2018

/cc @tych0

Before this there was no way to make --tag non-destructive, so we just
copy the semantics from umoci-config. This won't break existing scripts
because the default is still to override (just like it is with
umoci-config).

Signed-off-by: Aleksa Sarai <asarai@suse.de>
@cyphar cyphar added this to the 0.4.3 milestone Nov 11, 2018
@cyphar
Copy link
Member Author

cyphar commented Nov 11, 2018

LGTM.

@cyphar cyphar merged commit 80c353a into opencontainers:master Nov 11, 2018
cyphar added a commit that referenced this pull request Nov 11, 2018
  umoci: add --tag to umoci-insert

LGTMs: @cyphar
Closes #273
@cyphar cyphar deleted the insert-tag-flag branch November 11, 2018 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant