Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: get MacOS build working #318

Merged
merged 3 commits into from
Jun 22, 2020
Merged

*: get MacOS build working #318

merged 3 commits into from
Jun 22, 2020

Commits on Jun 21, 2020

  1. *: get MacOS build working 

    I don't have a MacOS machine (nor can we currently run the tests on
MacOS) but we can at least do a sanity-check by trying to build the
project on MacOS.

Most of the code changes move Linux-only functions (and tests) to
foo_linux{,_test}.go files, while code that was already usable on "unix"
platforms is moved to foo_unix{,_test}.go files. There was also a mild
refactor of some repeated test code, with it all being moved into
testutils. With these minor changes, umoci now builds.

Signed-off-by: Aleksa Sarai <asarai@suse.de>
    @cyphar
    cyphar committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    8b0064b View commit details
    Browse the repository at this point in the history

  2. travis: run unit tests on MacOS 

    This requires a little bit of working around MacOS-specific weirdnesses
(which are fine under POSIX but don't match Linux). The most obvious one
is the lack of 'readlink -f', but there's also the lack of sub-second
granularity of filesystem timesamps, and the default-follow behaviour of
link(2) when trying to hardlink a symlink.

Signed-off-by: Aleksa Sarai <asarai@suse.de>
    @cyphar
    cyphar committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    23e02ea View commit details
    Browse the repository at this point in the history

  3. CHANGELOG: mention MacOS support and OCI adoption 

    Signed-off-by: Aleksa Sarai <asarai@suse.de>
    @cyphar
    cyphar committed Jun 21, 2020
    Configuration menu
    Copy the full SHA
    af82115 View commit details
    Browse the repository at this point in the history